Discussion:
Small typo in iconv.m4
Hafiz Abid Qadeer
2018-11-06 16:37:23 UTC
Permalink
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.

The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"

OK to commit the attached patch?

2018-11-06 Hafiz Abid Qadeer <***@codesourcery.com>

* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.

Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
Simon Marchi
2018-11-07 15:27:42 UTC
Permalink
Post by Hafiz Abid Qadeer
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
Seems good from my point of view, but I can't approve.

Simon
Jeff Law
2018-11-07 22:41:38 UTC
Permalink
Post by Hafiz Abid Qadeer
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
THanks. I wasn't sure if you had commit privs, so I went ahead and
installed the patch.

Jeff
Eric Gallager
2018-11-09 17:57:19 UTC
Permalink
Post by Jeff Law
Post by Hafiz Abid Qadeer
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
THanks. I wasn't sure if you had commit privs, so I went ahead and
installed the patch.
Jeff
Does this have any effect on GCC bug 78251?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
Or any of the related bugs under "See Also" for that matter?
Jeff Law
2018-11-09 18:28:20 UTC
Permalink
Post by Eric Gallager
Post by Jeff Law
Post by Hafiz Abid Qadeer
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
THanks. I wasn't sure if you had commit privs, so I went ahead and
installed the patch.
Jeff
Does this have any effect on GCC bug 78251?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
Or any of the related bugs under "See Also" for that matter?
Certainly looks related. Though I think we're still going to see
pollution, just in a slightly different way.

jeff

Hafiz Abid Qadeer
2018-11-09 10:18:18 UTC
Permalink
Hi All,
Attached config/ patch was approved and committed in gcc repo. Ok to
commit it in the binutils-gdb repo?

2018-11-09 Hafiz Abid Qadeer <***@codesourcery.com>

* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gdb/configure: Regenerate.
* binutils/configure: Likewise.
* intl/configure: Likewise.

Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
Nick Clifton
2018-11-09 12:59:09 UTC
Permalink
Hi Hafiz,
Post by Hafiz Abid Qadeer
Hi All,
Attached config/ patch was approved and committed in gcc repo. Ok to
commit it in the binutils-gdb repo?
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gdb/configure: Regenerate.
* binutils/configure: Likewise.
* intl/configure: Likewise.
Approved, please apply. I should note however that the changelog
entry probably should be split up and added to the respective
subdirectories ChangeLog files. In particular I was confused because
I could not find a mention on the change in gcc's config/ChangeLog
file, and was rather surprised when I found it in the top level
ChangeLog file instead.

Cheers
Nick
Loading...