Discussion:
[PUSHED/OBV][PATCH] GDBserver: AArch64: Remove cannot_fetch/store_register
Alan Hayward
2018-11-23 14:11:24 UTC
Permalink
The cannot store/fetch register functions are only used for checking
if a register can be accessed using PEEKUSER/POKEUSER.
The AArch64 port doesn't support this method of access, so remove the
unused functions.

2018-11-23 Alan Hayward <***@arm.com>

* linux-aarch64-low.c (aarch64_cannot_store_register): Remove.
(aarch64_cannot_fetch_register): Likewise.
(struct linux_target_ops): Update references.
---
gdb/gdbserver/linux-aarch64-low.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index 1d34e319df..181e2666ab 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -84,22 +84,6 @@ is_sve_tdesc (void)
return regcache->tdesc->reg_defs.size () == AARCH64_SVE_NUM_REGS;
}

-/* Implementation of linux_target_ops method "cannot_store_register". */
-
-static int
-aarch64_cannot_store_register (int regno)
-{
- return regno >= AARCH64_NUM_REGS;
-}
-
-/* Implementation of linux_target_ops method "cannot_fetch_register". */
-
-static int
-aarch64_cannot_fetch_register (int regno)
-{
- return regno >= AARCH64_NUM_REGS;
-}
-
static void
aarch64_fill_gregset (struct regcache *regcache, void *buf)
{
@@ -3041,8 +3025,8 @@ struct linux_target_ops the_low_target =
{
aarch64_arch_setup,
aarch64_regs_info,
- aarch64_cannot_fetch_register,
- aarch64_cannot_store_register,
+ NULL, /* cannot_fetch_register */
+ NULL, /* cannot_store_register */
NULL, /* fetch_register */
aarch64_get_pc,
aarch64_set_pc,
--
2.17.2 (Apple Git-113)
Loading...